chenges to add universal member to groups #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwdcwd
reviewed
Jun 12, 2020
| if (res && res.records.length === 0) { | ||
| res = await tx.run(`CREATE (user:User {id: {id}}) RETURN user`, { id }) | ||
| if (res && res.records.length === 0) { | ||
| res = await tx.run(`CREATE (user:User {id: '00000000', universalUID: {id}}) RETURN user`, {id}) |
There was a problem hiding this comment.
is the Id field not allowed to be null ?
cwdcwd
reviewed
Jun 12, 2020
| res = await tx.run(`MATCH (e:${model} {id: {id}}) RETURN e`, {id}) | ||
|
|
||
| if (res && res.records.length === 0) { | ||
| res = await tx.run(`CREATE (user:User {id: {id}, universalUID: '00000000'}) RETURN user`, {id}) |
There was a problem hiding this comment.
can we put a null in instead of zeros?
cwdcwd
suggested changes
Jun 12, 2020
There was a problem hiding this comment.
Can we get the swagger updated as well?
I also want to add in fetching of the universal Id for a user when a normal TC member Id is used. I believe I need to add an endpoint to the U-Bahn API for this first though.
cc: @callmekatootie
| @@ -107,9 +107,9 @@ async function addGroupMember(currentUser, groupId, data) { | |||
| oldId: data.oldId, | |||
| name: group.name, | |||
| createdAt, | |||
| ...(currentUser === 'M2M' ? {} : { createdBy: currentUser.userId }), | |||
| ...(currentUser === 'M2M' ? {} : {createdBy: currentUser.userId}), | |||
| memberId: data.memberId, | |||
There was a problem hiding this comment.
Are we not using the M2M clientId for the createdUser/updatedUser values ?
| membershipId, | ||
| membershipType: data.membershipType, | ||
| createdAt, | ||
| createdBy: currentUser === 'M2M' ? '00000000' : currentUser.userId |
There was a problem hiding this comment.
can we use null instead of zeros?
| name: group.name, | ||
| createdAt, | ||
| ...(currentUser === 'M2M' ? {} : {createdBy: currentUser.userId}), | ||
| memberId: '00000000', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.